ID: | 3797 |
From: | Majenko Technologies <ma...@majenko.co.uk> |
Date: | Mon, 9 Mar 2020 11:56:11 +0000 |
Subject: | Re: [pcb-rnd] new: import schematics rewrite (call for test results) |
in-reply-to: | 3796 from ge...@igor2.repo.hu |
--00000000000026397505a06ab119 Content-Type: text/plain; charset="UTF-8" I have tested it with an updated version of my gaf-project system - seems to work. I have replaced the old import with: ImportSch(setup, gnetlist, [schematic files]) ImportSch() I had to do the second empty import since the first one doesn't seem to actually *do* the import, only set it up. Yes, I know that the setup should really only need to be be done once, but the list of schematic files is liable to change at any time in this system, so I just set it up again at every import. Seems to be fine. On Mon, Mar 9, 2020 at 6:37 AM <gedau@igor2.repo.hu> wrote: > Hi all, > > as of r29999, I've finished the following changes: > > - removed the old ImportGUI() action - please use ImportSch() action > instead > > - marked Import() deprecated and made it painful; it will be removed > in the next cycle; please use ImportSch() instead > > - removed the old Import() (gnetlist-only) menu item from File/Import; > please use the more generic "Import Schematics..." menu item instead > > - updated all docs to reflect the removal of the old plugin > > Please test and report if the new import schematics feature works. Please > report positive as well: if everything works - I really need to know if > the new code can replace the old. > > The current plan is (slight change from the previous) is to keep Import() > for one more cycle, with the bold warning, just for the unlikely scenario > that any of our non-svn users had automated scripts using the Import() > action. So I will remove the old import_sch plugin with Import() in the > next cycle. > > I've already removed the old GUI, so users of the GUI import workflow need > to switch this cycle (or with the next release). > > Details, from a month ago: > > On Sun, 2 Feb 2020, gedau@igor2.repo.hu wrote: > > >Hi all, > > > >after spending about 25 hours on this, I have more or less finished the > >first version of the new import schematics feature. > > > >Since majority of our users work from schematics and most of them use > >import schematics for forward annotation, this affects almost everybody. > >You are very likely affected too. Please read this mail and the material > >linked below. *** THESE CHANGES MOSTY LIKELY AFFECT YOU. *** > > > >This part of the code was a real dark corner. It really > >needed a full rewrite. I plan to remove the old code later in this cycle > >so please test the new code ASAP. > > > >Unfortunately the only way to clean up the mess was breaking backward > >compatibility in a few places. I tried to make the transition as painless > >as possible, I think it will be not that bad for most of us, but please > >prepare for the following changes: > > > >- some menus and action names changed > > > >- the most common flow, gnetlist, has only a very small change and the > >code usually will automatically switch over the configuration on the > first > >import with the new code (but we also have a GUI where you can check and > >chaneg the configuration, see the links below) > > > >- the exotic, very rarely used make based import needs some tuning, even > >in the Makefile, but we have detailed doc about that (see the links below) > > > >- since the old code could not import any other format or from any other > >external software, the rest of the changes will affect other > flows/formats > >only the good way: they became available for easier, single-click import > > > >In return we got a much cleaner, easier to maintain code, more > >modularity and major feature improvements on all parts. > > > > > >There are three documents dealing with these changes: > > > > > >1. Overview on what happened and why and what benefits we get: > > > >http://repo.hu/cgi-bin/pool.cgi?cmd=show&node=isch_overview > > > > > >2. a howto for easy switch from the old import schematics to the new: > > > >http://repo.hu/cgi-bin/pool.cgi?cmd=show&node=isch_switch > > > > > >3. a document about the new placement/removal configuration: > > > > > http://repo.hu/projects/pcb-rnd/user/09_appendix/action_details.html#elementlist > > > > > >The last one attempts to fix our long standing problem with how new > >subcircuits placed in an import and excess subcircuits after an import > >should be handled. It provides multiple options with an internal > structure > >that makes it easy to extend. If anyone shows active interest, I can make > >script binding to this so you can write an user script for placement and > >removal strategy. > > > >As an user I find the "frame" method of placement and "list" method of > >removal the best combination. > > > >While being there, I've also fixed a bug we had: the nonetlist flag on a > >subcircuit makes sure it is not scheduled for removal in an import. This > >is a good alternative to "no refdes" subcircuits. > > > >Please test the new code and report any bug or srangeness. > > > >Best regards, > > > >Igor2 > > > > > > > > > -- *Matt Jenkins* Majenko Technologies https://majenko.co.uk --00000000000026397505a06ab119 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">I have tested it with an updated version of my gaf-project= system - seems to work.=C2=A0 I have replaced the old import with:<div><fo= nt face=3D"monospace"><br></font></div><div><font face=3D"monospace">=C2=A0= =C2=A0 ImportSch(setup, gnetlist, [schematic files])</font></div><div><fon= t face=3D"monospace">=C2=A0 =C2=A0 ImportSch()</font></div><div><br></div><= div>I had to do the second empty import since the first one doesn't see= m to actually *do* the import, only set it up. Yes, I know that the setup s= hould really only need to be be done once, but the list of schematic files = is liable to change at any time in this system, so I just set it up again a= t every import. Seems to be fine.</div><div><br></div></div><br><div class= =3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Mar 9, 2020 = at 6:37 AM <<a href=3D"mailto:gedau@igor2.repo.hu">gedau@igor2.repo.hu</= a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0p= x 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi= all,<br> <br> as of r29999, I've finished the following changes:<br> <br> - removed the old ImportGUI() action - please use ImportSch() action <br> instead<br> <br> - marked Import() deprecated and made it painful; it will be removed <br> in the next cycle; please use ImportSch() instead<br> <br> - removed the old Import() (gnetlist-only) menu item from File/Import; <br> please use the more generic "Import Schematics..." menu item inst= ead<br> <br> - updated all docs to reflect the removal of the old plugin<br> <br> Please test and report if the new import schematics feature works. Please <= br> report positive as well: if everything works - I really need to know if <br= > the new code can replace the old.<br> <br> The current plan is (slight change from the previous) is to keep Import() <= br> for one more cycle, with the bold warning, just for the unlikely scenario <= br> that any of our non-svn users had automated scripts using the Import() <br> action. So I will remove the old import_sch plugin with Import() in the <br= > next cycle. <br> <br> I've already removed the old GUI, so users of the GUI import workflow n= eed <br> to switch this cycle (or with the next release).<br> <br> Details, from a month ago:<br> <br> On Sun, 2 Feb 2020, <a href=3D"mailto:gedau@igor2.repo.hu" target=3D"_blank= ">gedau@igor2.repo.hu</a> wrote:<br> <br> >Hi all,<br> ><br> >after spending about 25 hours on this, I have more or less finished the= <br> >first version of the new import schematics feature.<br> ><br> >Since majority of our users work from schematics and most of them use <= br> >import schematics for forward annotation, this affects almost everybody= . <br> >You are very likely affected too. Please read this mail and the materia= l <br> >linked below. *** THESE CHANGES MOSTY LIKELY AFFECT YOU. ***<br> ><br> >This part of the code was a real dark corner. It really <br> >needed a full rewrite. I plan to remove the old code later in this cycl= e <br> >so please test the new code ASAP.<br> ><br> >Unfortunately the only way to clean up the mess was breaking backward <= br> >compatibility in a few places. I tried to make the transition as painle= ss <br> >as possible, I think it will be not that bad for most of us, but please= <br> >prepare for the following changes:<br> ><br> >- some menus and action names changed<br> ><br> >- the most common flow, gnetlist, has only a very small change and the = <br> >code usually will automatically switch over the configuration on the fi= rst <br> >import with the new code (but we also have a GUI where you can check an= d <br> >chaneg the configuration, see the links below)<br> ><br> >- the exotic, very rarely used make based import needs some tuning, eve= n <br> >in the Makefile, but we have detailed doc about that (see the links bel= ow)<br> ><br> >- since the old code could not import any other format or from any othe= r <br> >external software, the rest of the changes will affect other flows/form= ats <br> >only the good way: they became available for easier, single-click impor= t<br> ><br> >In return we got a much cleaner, easier to maintain code, more <br> >modularity and major feature improvements on all parts.<br> ><br> ><br> >There are three documents dealing with these changes:<br> ><br> ><br> >1. Overview on what happened and why and what benefits we get:<br> ><br> ><a href=3D"http://repo.hu/cgi-bin/pool.cgi?cmd=3Dshow&node=3Disch_o= verview" rel=3D"noreferrer" target=3D"_blank">http://repo.hu/cgi-bin/pool.c= gi?cmd=3Dshow&node=3Disch_overview</a><br> ><br> ><br> >2. a howto for easy switch from the old import schematics to the new:<b= r> ><br> ><a href=3D"http://repo.hu/cgi-bin/pool.cgi?cmd=3Dshow&node=3Disch_s= witch" rel=3D"noreferrer" target=3D"_blank">http://repo.hu/cgi-bin/pool.cgi= ?cmd=3Dshow&node=3Disch_switch</a><br> ><br> ><br> >3. a document about the new placement/removal configuration:<br> ><br> ><a href=3D"http://repo.hu/projects/pcb-rnd/user/09_appendix/action_deta= ils.html#elementlist" rel=3D"noreferrer" target=3D"_blank">http://repo.hu/p= rojects/pcb-rnd/user/09_appendix/action_details.html#elementlist</a><br> ><br> ><br> >The last one attempts to fix our long standing problem with how new <br= > >subcircuits placed in an import and excess subcircuits after an import = <br> >should be handled. It provides multiple options with an internal struct= ure <br> >that makes it easy to extend. If anyone shows active interest, I can ma= ke <br> >script binding to this so you can write an user script for placement an= d <br> >removal strategy. <br> ><br> >As an user I find the "frame" method of placement and "l= ist" method of <br> >removal the best combination.<br> ><br> >While being there, I've also fixed a bug we had: the nonetlist flag= on a <br> >subcircuit makes sure it is not scheduled for removal in an import. Thi= s <br> >is a good alternative to "no refdes" subcircuits.<br> ><br> >Please test the new code and report any bug or srangeness.<br> ><br> >Best regards,<br> ><br> >Igor2<br> ><br> ><br> ><br> <br> <br> </blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"= class=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><b>Matt J= enkins</b><div>Majenko Technologies</div><div><a href=3D"https://majenko.co= .uk" target=3D"_blank">https://majenko.co.uk</a></div></div></div></div></d= iv> --00000000000026397505a06ab119--
Reply subtree:
3797 Re: [pcb-rnd] new: import schematics rewrite (call for test results) from Majenko Technologies <ma...@majenko.co.uk>