| ID: | 3705 |
| From: | ge...@igor2.repo.hu |
| Date: | Thu, 23 Jan 2020 06:10:28 +0100 (CET) |
| Subject: | Re: [pcb-rnd] reversed missing layer export warning |
| in-reply-to: | 3566 from ge...@igor2.repo.hu |
| replies: | 3707 from pc...@cuvoodoo.info |
Hi cuvoodoo, On Fri, 29 Nov 2019, gedau@igor2.repo.hu wrote: > On Fri, 29 Nov 2019, cuvoodoo wrote: <snip> >>it will not warn if the layer is empty, even if okempty option is absent. > >Thanks, I will revise this (meaning: gerber exporter, cam mode, >which layer group types should warn for being empty) <snip> >>it will warn if the corresponding layer (group) is missing: >> >>gerber cam export for '%base%.g%top_offs+1%l=intern-copper' failed to produce any content >> >>with the empty option present, it will not warn anymore. > >That's normally good: if your job addresses a layer group that's not >there, we should warn by default. > >However, I see a problem: we should have a different warning for >"addressed layer group does not exist" and "groups exist, but are empty". >But this is a rather big change (with a lot of risk for introducing >bugs) for a small benefit, so should happen in a cleanup phase. As of r29239, I've fixed and documented both of these, please test and ACK! Fix details: - I've separated the error message by reason: there is one for "no layer group exists" (when your cam job says "export top silk" and there is no top silk layer group at all) and another error message for the case when layer groups were there but empty (no objects drawn on them) - you can get only one of the two warnings; if layer groups were missing, you won't get an extra warning for not having objects - note: if your outfile is built of 2 or more layer groups, the group missing warning will be emitted only if none of the groups exist; e.g. if you have a rule that exports all top layer groups in top.png, you won't get a warning for a missing top silk, you get a warning only if none of the addressed top layer groups existed. In other words: the "layer group missing" warning means absolutely nothing existed of what you wanted to export in that file, while if you are merging multiple groups into an outfile it is accepted as normal case if a few groups are missing as long as at least one exists - I've separated the warning suppress keywords for them; they are called okempty-group and okempty-content, respectively - I've kept the original okempty keyword too, in a compatible manner: it is a shorthand that enables both okempty-group and okempty-content, so using that you won't see any warning about these Note: these are only about controlling how warnings are emitted; as discussed in my original reply, it is intentional that different export plugins have different policy about creating or not creating empty files, depending on file format conventions. Best regards, Igor2
Reply subtree:
3705 Re: [pcb-rnd] reversed missing layer export warning from ge...@igor2.repo.hu
3707 Re: [pcb-rnd] reversed missing layer export warning from pc...@cuvoodoo.info
3708 Re: [pcb-rnd] reversed missing layer export warning from ge...@igor2.repo.hu
3734 Re: [pcb-rnd] reversed missing layer export warning from pc...@cuvoodoo.info
3738 Re: [pcb-rnd] reversed missing layer export warning from ge...@igor2.repo.hu